Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: compiz https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198944 krh@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO_REPORTER |ASSIGNED ------- Additional Comments From krh@xxxxxxxxxx 2006-07-17 21:59 EST ------- Thanks for the review, Jesse, comments below. (In reply to comment #3) > How does this spec compare to the one in the Extras review? Does this one have > the fixes and updates generated from that review? To the extent that it makes sense, yes. > NEEDSWORK: > - release string should be whole number unless it is a pre-release (snapshot). > If it is a snapshot, as it looks like, you should use the prelease naming > scheme: > http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-d97a3f40b6dd9d2288206ac9bd8f1bf9b791b22a > - dist tag is %{?dist} not %{dist} > - gconf stuff should follow the scriptletsnippits or have good reason not to: > http://fedoraproject.org/wiki/ScriptletSnippets#head-ff64cd482595764f672082d5a3b83e1fc22962e8 > - changelog shouldn't use dist tag as part of the version-release. > - missing br gettext Fixed (thanks, Matthias). > rpmlint output (once added gettext) > W: compiz-debuginfo invalid-license X11/MIT/GPL > W: compiz invalid-license X11/MIT/GPL > W: compiz invalid-license X11/MIT/GPL > > Ignorable I suppose, but it would help if upstream included a LICENSE file. Upstream doesn't include a license because different parts of the project are under different licenses. You need to check individual files for their license. > W: compiz macro-in-%changelog dist > > Leave out the macro. > > W: compiz mixed-use-of-spaces-and-tabs > > Ignorable > > W: compiz non-conffile-in-etc /etc/gconf/schemas/compiz.schemas > > Should this be marked a conf file? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review