Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199192 Summary: Review Request: kadu - Gadu-Gadu client for online messaging Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@xxxxxxxxxxxxx ReportedBy: mr.ecik@xxxxxxxxx QAContact: fedora-package-review@xxxxxxxxxx Spec URL: http://ecik.zspswidwin.pl/kadu/kadu.spec SRPM URL: http://ecik.zspswidwin.pl/kadu/kadu-0.5.0-1.20060716svn.src.rpm Description: Hi! This is one of my first packages so I need a sponsor. In bug 165878 there is another kadu review request but reporter has abondoned it and I have no permissions to close that bug. Kadu is Gadu-Gadu protocol client, which is very popular in Poland, probably it is the most popular instant messaging application in Poland. The last stable version is 0.4.3, but I think that 0.5.0 svn version is stable enough, so it can be placed in Extras. Few words about SPEC: 1. I have defined two macros: mod_files and mod_files2 to make easier creating %files section of subpackages. Files in subpackages are mostly very similar so I didn't want to write the same repeatedly. 2. I know the first lines of %prep section don't look professional but it is the simpliest way to unpack all archives. Otherwise I would have to write my own lines to unpack each one and SPEC file would look more complicated. The last %setup line simply does nothing - it is only to set kadu dir as sources dir. But if you say that %prep cannot look like that, I'll change it. 3. There is no %doc tag, because AUTHORS, README etc. files are used by Kadu in About window so they must be in proper directory. Well, I think that's all. SPEC is a little complex so I can explain each line in it, because everything is justified :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review