Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gkrellm-wifi - Wireless monitor plugin for the GNU Krell Monitors https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197981 ville.skytta@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |ville.skytta@xxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From ville.skytta@xxxxxx 2006-07-16 16:24 EST ------- Blockers: - Tarball is not upstream one, sha1sums: package: 52d13482f7ea71ca0f5613ac5209cbe7d8385f42 upstream: 45888e68822189bedb11e3d77e6d5e8eacb6d507 There are also substantial differences in their contents. - Missing dependency on gkrellm. Other notes/suggestions: - Add back "ExcludeArch: s390 s390x" like it was kind of in the FC package for benefit of folks who rebuild FE packages for example for RHEL. - A patch/sed one liner replacing unwanted stuff in CFLAGS with $RPM_OPT_FLAGS could be easier to maintain than copy-pasting all flags between Makefile and the specfile. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review