Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gkrellm - Multiple stacked system monitors in one process https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197967 ------- Additional Comments From ville.skytta@xxxxxx 2006-07-16 10:55 EST ------- Yes, "|| :" should be added to condrestart. And IMO the snippets page should be fixed to use the scripts directly, I see no benefit from using /sbin/service instead of them. Some people have mentioned that *not* using it makes it easier to get rid of initscripts altogether and to use another init system. I don't know the details and that wouldn't work without other changes anyway, so it's not a blocker. Other issues: - Seems that there's no need to require the main package in -devel, nothing in it depends on anything in main, right? - Desktop file has been renamed from gnome-gkrellm.desktop to fedora-gkrellm.desktop, which will break eg. buttons added to the KDE panel from menus using the "add application to panel" function, and I believe there are other similar problems in other desktops if that's done, so I suggest reverting the rename. - Regression in desktop entry: StartupNotify=false prevents KDE's built-in startup notification from working. The key should be just removed. - The default gkrellmd.conf uses "proc" as the group to drop privs to. That group doesn't exist, should probably be gkrellmd instead. - groupadd should be done with the -r argument. - The switch from the builtin sensors stuff to libsensors appears to break existing sensors configs, my configured sensors just disappeared from gkrellm (but reconfiguring the sensors worked). Would there be a sane way to prevent this? If not, not a blocker. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review