Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lsscsi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198928 ------- Additional Comments From paul@xxxxxxxxxxxx 2006-07-15 09:41 EST ------- (In reply to comment #1) > * In build, why not use "%configure"? Similarly, in install, why not > "%makeinstall"? %makeinstall is deprecated. See the "Macros" section of the Packaging Guidelines. http://fedoraproject.org/wiki/Packaging/Guidelines > * There may be comments on the test before "rm -rf ..." in %clean. I think it's > ok, as it will always evaluate to true in the buildsys, but it could be nixed > for brevity's sake. Not only that but the tests are completely redundant since a buildroot is explicitly specified in the spec file. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review