Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Atlas-C++ - WorldForge message protocol library Alias: Atlas-C++ https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198835 ------- Additional Comments From wart@xxxxxxxxxx 2006-07-14 13:51 EST ------- (In reply to comment #1) > -rpmlint output: > W: Atlas-C++ undefined-non-weak-symbol /usr/lib64/libAtlasObjects-0.6.so.1.0.0 > _ZNK5Atlas9Exception4whatEv ... rpmlint on FC4 x86_64 and FC5 i386 both missed this one. > === MUST === > - Add Requires: pkgconfig to devel package Done. > - Comments say test fails on FC6, but infact it is failing on all x86_64 arches > because of an x86_64 warning. Patch the code to not use -Werror so that checks > can be run I think it would be better just to fix the test code and keep the -Werror. This might get sent upstream. > - Fix linking of all the .so files, they should be linked with -lAtlas and > libAtlas needs to be built first. I wonder if this is a smp_mflags build > - Explain why you do not build with optional zlib or libbz2 Because I didn't notice the configure output? :) > - README indicates that this package requires socket streams such as skstream, > explain why this is not in the Requires It probably should be. But since the package that Requires: this one also Requires: skstream directly, I didn't catch this. > - Why are man pages in doc/man not installed? Oversight. I've added most of them. Others are not included as they contain the build root path in the man page name (probably some doxygen artifact) > - Should tutoral/ be installed? No. These are doxygen sources. The tutorial is included in %doc doc/html > - Fix license to match actual license Fixed. > - Fix Source0 URL so that I can actually verify the upstream source is 0.6.0 > actually out yet? Works for me? > - Why name Atlas-C++ instead of atlascpp? Because even though upstream uses both Atlas-C++ and atlas-cpp, the former best matches the actual tarball name. I'll post a new srpm once the tests have been fixed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review