Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: varconf - Configuration library used by WorldForge apps Alias: varconf https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198831 ------- Additional Comments From chris.stone@xxxxxxxxx 2006-07-14 03:21 EST ------- - rpmlint output: W: varconf-devel no-documentation okay to ignore, I dont see any documentation which should go in devel - package named according to package naming guidelines - spec file name matches package %{name} - package meets packaging guidelines - license in spec file is compatible with open source license O package does not match actual upstream license - license file included in %doc - spec file written in American english - spec file is legible - sources match upstream b8f30226a1fee727fd124f716d8eb72e varconf-0.6.4.tar.gz - package successfully compiles and builds on x86_64 FC-5 - all build dependencies are in BuildRequires - package does not contain locales - package properly uses %post/%postun ldconfig - package is not relocatable - package owns all directories it creates - package does not contain duplicate files - file permissions are set properly - package contains proper %clean section - macro usage is consistant - package contains permissible content - package does not contain large documentation - files in %doc do not affect runtime - header files are in devel - pkgconfig files are in devel - libraries w/o suffix are in devel - devel package requires base package - package does not contain .la files - package is not a GUI needing .desktop files - package does not own files or directories owned by other packages ==== MUST ==== - devel package should have Requires: pkgconfig - make check should use smp flags - make check should be patched to work, (not ||:) all you need to do is add #include <assert.h> once conftest is created, you need to: cd tests ; ./conftest < conf.cfg - fix license to match actual upstream license -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review