Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eris - Client-side session layer for Atlas-C++ Alias: eris https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198837 ------- Additional Comments From chris.stone@xxxxxxxxx 2006-07-14 01:23 EST ------- - rpmlint output: W: eris incoherent-version-in-changelog 1.3.11-0.1 1.3.11-1.fc5 Must fix changelog version number - package name meets package naming guidelines - spec file name matches package %{name} - package meets packaging guidelines - package is licensed with open source compatible license - license matches actual upstream license - license file included in %doc - spec file written in American english - spec file is legible - source file matches upstream 632bb5ad0e8cbcf59c8f26c50c320b7d eris-1.3.11.tar.gz - package successfully compiles and builds on x86_64 FC-5 O package does not list all build dependencies, configure checks for glib-2.0 which is not provided - package does not contain locales - package contains proper %post/%postun ldconfig calls - package is not relocatable - package owns all directories it creates - package does not contain duplicate files - file permissions are set properly - package contains proper %clean section - macro usage is consistent - package contains permissible content - package does not contain large documentation - files in %doc do not affect runtime - header files are in devel package - pkgconfig files are in devel - libraries w/o suffix are in devel - devel package requires base package - package does not contain any .la files - package is not a GUI needing a .desktop file - package does not own files or directories owned by other packages ==== MUST ==== - Remove pkgconfig from BuildRequries, this should be picked up by the devel packages - Fix changelog version number - "outpu" in description should be "output" - Why is glib-2.0 not added in BuildRequires? - Add a %check section - %doc in devel should be docs/html/* -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review