Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: skstream - C++ I/O library for WorldForge apps Alias: skstream https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198832 ------- Additional Comments From chris.stone@xxxxxxxxx 2006-07-13 22:56 EST ------- - rpmlint output: W: skstream-devel no-documentation okay to ignore, I don't see any documentation which should go in devel - package is named according to package naming guidelines - spec filename matches package %{name} - package meets package naming guidelines - package licensed with open source compatible license - license field matches actual license - license included in %doc - spec file written in American english - spec file is legible - sources match upstream 0c5ec89551bc0900b2e708992f321794 skstream-0.3.5.tar.gz - package successfully compiles and builds on x86_64 FC-5 - All build dependencies listed in BuildRequires, optional dependencies not listed (zlib) - package does not contain locales - ldconfig properly called in %post/%postun - package is not relocatable - package owns all directories it creates - package does not contain any duplicate files - permissions on files is set properly - package contains proper %clean section - macro usage is consistant - package contains permissible content - package does not contain large documentation - files in %doc do not affect runtime - header files are contained in devel package - pkgconfig files are in devel package - library files w/o suffix are in devel - devel package requires base package - package does not contain .la files - package does not own files or directories owned by other packages ==== MUST ==== - Add Requires: pkgconfig to devel package - Explain why this is not compiled with optional zlib library - contact upstream about make docs error ==== NOTES ==== - make check has some failures, but these are okay, they require the echo service to be enabled or be run as root. I enabled echo on my system and ran make check as root and these tests pass. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review