Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: steghide - A Steganography Program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198691 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NOTABUG CC| |panemade@xxxxxxxxx ------- Additional Comments From panemade@xxxxxxxxx 2006-07-13 15:01 EST ------- == Not an official review as I'm not yet sponsored == Mock build for development i386 is sucessfull with warnings CvrStgObject.h:40: warning: 'class CvrStgObject' has virtual functions but non-virtual destructor MCryptPPTest.cc: In member function 'bool MCryptPPTest::genericTestDecryption()': MCryptPPTest.cc:47: warning: control reaches end of non-void function MCryptPPTest.cc: In member function 'bool MCryptPPTest::genericTestEncryption()': MCryptPPTest.cc:43: warning: control reaches end of non-void function * MUST Items: - rpmlint shows no error. - dist tag is present. - The package is named according to the Package Naming Guidelines. - The spec file name matching the base package steghide, in the format steghide.spec. - This package meets the Packaging Guidelines. - The spec file for the package MUST be legible. - The package is licensed with an open-source compatible license GPL. - This package includes License file COPYING. - This source package includes the text of the license in its own file,and that file, containing the text of the license for the package is included in %doc. - The sources used to build the package matches the upstream source, as provided in the spec URL. md5sum is correct (5be490e24807d921045780fd8cc446b3) - This package successfully compiled and built into binary rpms for i386 architecture. - This package did not containd any ExcludeArch. - This package handled locales properly. This is done by using the %find_lang macro. Not used %{_datadir}/locale/*. - This package owns all directories that it creates. - This package did not contain any duplicate files in the %files listing. - This package have a %clean section, which contains rm -rf $RPM_BUILD_ROOT. - This package used macros. - Document files are included like README. - Package did NOT contained any .la libtool archives. Also, * Source URL is present and working. * BuildRoot is correct BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * BuildRequires is correct * Package is working fine on i386. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review