Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: stacaccli - Stateless Cached Client Tools https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197791 markmc@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO_REPORTER |ASSIGNED ------- Additional Comments From markmc@xxxxxxxxxx 2006-07-12 09:13 EST ------- Thanks (In reply to comment #2) > - pyver checking not necessary. Python now autoadds the python(abi) requirement. Done. > - needs 'noarch' listed in ExclusiveArch. Done. > E: stacaccli explicit-lib-dependency libxml2-python Not actually a lib dependency. Just matches the regex. > E: stacaccli non-executable-script > /usr/lib/python2.4/site-packages/stacaccli/common/bootloader.py 0644 [snip more non-executable-script] Yes, they're python modules and not intended to be executable, even though they start with #! Fairly common with python code e.g. rpmlint yum. > W: stacaccli incoherent-init-script-name stacacclid i.e. rename the initscript stacaccli ? It starts the daemon (stacacclid), so I think the current name is probably more appropriate. > W: stacaccli incoherent-version-in-changelog 0.1-1 0.2-1 Fixed. > W: stacaccli non-conffile-in-etc /etc/rwtab.d/stacaccli /etc/rwtab isn't marked with %config, and I don't think it's correct to mark this one either. > W: stacaccli strange-permission stacaccli.spec 0600 Fixed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review