Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pymsnt - MSN Transport for Jabber Servers https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197847 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-07-11 20:16 EST ------- Looks like you just beat 0.11.1 ouut. Some rpmlint issues: E: pymsnt no-status-entry /etc/rc.d/init.d/pymsnt W: pymsnt mixed-use-of-spaces-and-tabs Indeed, the init script doesn't accept status, and some lines in the spec are indented with tabs while others use spaces. (I.e. spaces for Source0 and tabs for Source1.) You don't seem to include the spool directory in the package. In case you find making the %files list tedious, you might consider using the stuff at the end of http://fedoraproject.org/wiki/Packaging/Python, which gets it down to three find statements and a few calls to sed. You don't seem to include the spool directory in the package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review