Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: em8300(-kmod) - Hollywood+/DXR3 hardware MPEG decoder drivers and tools https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189400 ------- Additional Comments From ville.skytta@xxxxxx 2006-07-11 15:45 EST ------- Thanks for the thorough review. modules/em8300.uc is indeed the firmware blob (which should be installed as /lib/firmware/em8300.bin), and the kmod package used accidentally the wrong source tarball even though the firmware wasn't installed. The microcode/firmware extractor depends on perl which was a bigger issue a long time ago when things were packaged differently, but that's no longer the case. Devel doesn't require the main package or -utils simply because there's nothing in it that would require those, -devel is self contained. Adding the dependency would additionally inflict the need to install a kernel and a suitable em8300 module package for it which seems just useless and may be a problem in eg. some build systems. Strip vs not-stripped: the modules are stripped of something indeed, but something is also left behind which causes "file" to report "not stripped" and rpmlint uses that for its check. Note: it's the same as for all kernel modules, including those shipped with the kernel itself. I'm not compentent to analyze this, to me it's just how /usr/lib/rpm/debugedit seems to behave ;) Other than those: http://cachalot.mine.nu/5/SRPMS/em8300-0.15.3-4.src.rpm * Tue Jul 11 2006 Ville Skyttä <ville.skytta at iki.fi> - 0.15.3-4 - Require >= em8300-kmod, not = kmod-em8300 (#189400). - Move microcode extractor to -utils as em8300-mc_ex (like Debian) (#189400). - Don't ship microcode_upload.pl, the modules and em8300setup already can handle that. http://cachalot.mine.nu/5/SRPMS/em8300-kmod-0.15.3-6.2.6.17_1.2145_FC5.src.rpm * Tue Jul 11 2006 Ville Skyttä <ville.skytta at iki.fi> - 0.15.3-6 - Enable PPC SMP builds (#189400). - Use firmwareless tarball (#189400). - Untabify specfile (#189400). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review