Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xorg-x11-drv-amd https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198025 jkeating@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO_REPORTER AssignedTo|notting@xxxxxxxxxx |jkeating@xxxxxxxxxx OtherBugsDependingO|188265 |188267 nThis| | ------- Additional Comments From jkeating@xxxxxxxxxx 2006-07-11 10:05 EST ------- FEEDBACK: - Since you went to the trouble of defining gitdate, might as well use it in Source0 (: - driver packages shouldn't own %{_libdir}/x11/modules or %{_libdir}/x11/modules/drivers. These are owned by xorg-x11-server-Xorg, which all drivers require. Other than that, it looks good. Fix those, and I can approve it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review