Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_auth_ntlm_winbind - NTLM authentication for the Apache web server using winbind daemon https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188138 ------- Additional Comments From rdieter@xxxxxxxxxxxx 2006-07-10 12:06 EST ------- A few initial comments (and given enough time later this week, I'll hopefully be able to pull off a full review): 1. Drop Epoch: 0 it's not necessary, nor desired. 2. Yuck, %post, %triggerin squid Changing dir ownership in a scriplet is bad, especially, since the target is owned by another package (samba-common). I can see where you're coming from here, but in the end, it's just an unacceptable hack. Arg, on checking, it appears squid does that same thing! A better solution would be to ask/bug the samba maintainer to make /var/cache/samba/winbindd_privileged group writable (owned by some group, say, samba). Then apache and squid could simply add themselves to this group on install. (I'll go file a bug/enhancement-request for that now...) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review