Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pcb https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189482 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ASSIGNED AssignedTo|Jochen@xxxxxxxxxxxxxxx |j.w.r.degoede@xxxxxx ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-07-09 06:41 EST ------- Since no one has commented lets just handle things in this Review Request. Here is a full Review for Chitlesh's version, not Peter's! : MUST: ===== * rpmlint output is: E: pcb info-dir-file /usr/share/info/dir This must be fixed, add "rm -f ${RPM_BUILD_ROOT}%{_infodir}/dir" in %install * Package and spec file named appropriately * Packaged according to packaging guidelines * License (GPL) ok, license fileS included * spec file is legible and in Am. English. * Source matches upstream * Compiles and builds on devel-x86_64 * BR: ok * No locales * No shared libraries * Not relocatable * Package owns / or requires all dirs (with some strangeness see Must fix below) * No duplicate files & Permissions ok * %clean & macro usage OK * Contains code. * %doc does not affect runtime, and isn't large enough to warrent a sub package * no -devel package needed, no libs / .la files. * .desktop file as required and properly installed MUST fix: ========= * rpmlint output is: E: pcb info-dir-file /usr/share/info/dir This must be fixed, add "rm -f ${RPM_BUILD_ROOT}%{_infodir}/dir" in %install. Without this fixed installing it gives: Preparing... ########################################### [100%] file /usr/share/info/dir from install of pcb-0.20060422-1 conflicts with file from package info-4.8-11 You probaly didn't see this on your system because the dir file getting generated depends on the system configuration on which the package is build, hence the -f to rm, so that if the dir file isn't there it doesn't cause an error. * You are missing the following requires for the texinfo script: Requires(post): /sbin/install-info Requires(preun): /sbin/install-info Should fix: =========== * Add an icon and install it under: %{_datadir}/icons/hicolor/32x32/apps Where 32x32 is the size of the icon, please do ls /usr/share/icons/hicolor/ to see the available valid sizes, if the icon doesn't match any pick the closest. * Once the icon is in the proper plase you must add %post(un) script to update the icon-cache see: http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review