Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: puppet https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180571 jpmahowald@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |jpmahowald@xxxxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From jpmahowald@xxxxxxxxx 2006-07-08 00:03 EST ------- Built against 1.3.3-1 facter. rpmlint is noisy. E: puppet zero-length /usr/share/doc/puppet-0.18.2/examples/root/etc/configfile E: puppet zero-length /usr/share/doc/puppet-0.18.2/examples/root/etc/otherfile Ignore. E: puppet non-standard-uid /var/lib/puppet puppet E: puppet non-standard-gid /var/lib/puppet puppet E: puppet non-standard-uid /var/log/puppet puppet E: puppet non-standard-gid /var/log/puppet puppet E: puppet non-standard-uid /var/run/puppet puppet E: puppet non-standard-gid /var/run/puppet puppet The user/group was added. Ignore. W: puppet doc-file-dependency /usr/share/doc/puppet-0.18.2/examples/root/bin/sleeper /usr/bin/ruby Required for puppet, ok. E: puppet incoherent-subsys /etc/rc.d/init.d/puppet puppet} W: puppet mixed-use-of-spaces-and-tabs Cosmetic. W: puppet-server no-documentation Fine. W: puppet-server incoherent-init-script-name puppetmaster Not puppet, ok. Defines %ruby_sitelibdir as per guidlines. - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR Do you need both of: Requires: ruby >= 1.8.1 and Requires: ruby(abi) = 1.8 ? Merely redundant if so. - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review