Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: NAS The Network Audio System https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197936 ------- Additional Comments From rdieter@xxxxxxxxxxxx 2006-07-07 13:29 EST ------- OK, I'll review this. More comments: 1. Other good things to %doc: %doc BUGS FAQ HISTORY TODO 2. man3 bits should be in -devel (they're api man pages) 3. rename /etc/nas/nasd.conf.eg -> /etc/nas/nasd.conf 4. changelog format is goofy, instead of: 1.8.-2%{?dist} use just 1.8-2 (you can leave the %{?dist} appended if you like, that's your preference), just don't have a '.-' in there. 5. (fc5) needs BuildRequires: libXext-devel libXt-devel (found by trying to build in a fc5 mock buildroot) 6. Would be nice to be buildable on < fc5. Could be done if you don't mind doing something like: BuildRequires: bison flex %if "%{?fedora}" > "4" BuildRequires: imake BuildRequires: libXaw-devel libXext-devel libXpm-devel libXp-devel libXt-devel %else BuildRequires: xorg-x11-devel %endif and for %install, use: make DESTDIR=$RPM_BUILD_ROOT install install.man \ BINDIR=%{_bindir} \ INCROOT=%{_includedir} \ LIBDIR=%{_libdir}/X11 \ SHLIBDIR=%{_libdir} \ USRLIBDIR=%{_libdir} \ MANPATH=%{_mandir} 7. Re license, mandriva uses License: Public Domain ?? (: 8. Include init script for nasd, I'll attach what Mandriva uses add to spec: Source1: nasd.init Source2: nasd.sysconfig and in %install install -p -m755 -D %{SOURCE1} $RPM_BUILD_ROOT%{_initrddir}/nasd install -p -m644 -D %{SOURCE2} $RPM_BUILD_ROOT%{_sysconfdir}/sysconfig/nasd and in %files: %config(noreplace) %{_sysconfdir}/sysconfig/nasd %{_initrddir}/nasd and scriptlets: %preun if [ $1 = 0 ] ; then /sbin/chkconfig --del nasd /sbin/service nasd stop >/dev/null 2>&1 ||: fi %post /sbin/chkconfig --add nasd -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review