Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: buildbot https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197565 ------- Additional Comments From giallu@xxxxxxxxx 2006-07-07 12:21 EST ------- (In reply to comment #3) > 1) used I changed it to Development/Tools as Development/Build Tools is not a > valid group. That's good, but AFAIK "Development/Build Tools" _is_ a valid group. At least it is listed in http://fedoraproject.org/wiki/RPMGroups > 5) I am choosing to leave this one it. buildbot is 100x more functional with it. OK > 7) its only a small files list, so in this case I will leave it. If it were > bigger, then I would certainly use the method suggested on the wiki. Good I can't see any other blockers. rpmlint is silent on the srpm while on the actual rpm gives 3 warnings I would ignore: W: buildbot wrong-file-end-of-line-encoding /usr/share/doc/buildbot-0.7.3/contrib/windows/buildbot2.bat W: buildbot doc-file-dependency /usr/share/doc/buildbot-0.7.3/contrib/run_maxq.py /usr/bin/env W: buildbot doc-file-dependency /usr/share/doc/buildbot-0.7.3/contrib/svn_buildbot.py /usr/bin/env -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review