Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-DateTime-Set https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197726 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-07-06 18:29 EST ------- The requires list for this module comes up with: perl(Set::Infinite) >= 0.59 perl(Set::Infinite) >= 0.59 so I think you can drop your explicit Requirement for that module. (I did so and rebuilt and only one of those showed up.) Since this is the only issue, I'll go ahead and approve this. Perhaps you could pass on the favor and review someone else's package. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * source files match upstream: 777f0d8c2f6c6092cd7a70bf7e701831 DateTime-Set-0.25.tar.gz * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64) (one dependency added locally) * rpmlint is silent. * noarch package; no debuginfo package * final provides and requires are sane: perl(DateTime::Set) = 0.25 perl(DateTime::Span) perl(DateTime::SpanSet) perl(Set::Infinite::_recurrence) perl-DateTime-Set = 0.25-1.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(DateTime) >= 0.12 perl(DateTime::Duration) perl(DateTime::Infinite) perl(DateTime::Set) perl(DateTime::Span) perl(DateTime::SpanSet) perl(Params::Validate) perl(Set::Infinite) >= 0.59 perl(Set::Infinite) >= 0.59 perl(Set::Infinite::_recurrence) perl(constant) perl(strict) perl(vars) * %check is present and all tests pass: All tests successful. Files=19, Tests=196, 57 wallclock secs (55.93 cusr + 0.67 csys = 56.60 CPU) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED, just remove the explicit Requires: perl(Set::Infinite) >= 0.59 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review