Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libical - A library for parsing iCal component https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197765 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@xxxxxxxxx ------- Additional Comments From panemade@xxxxxxxxx 2006-07-06 04:35 EST ------- == Not an official review as I'm not yet sponsored == * Mock build for development i386 is sucessfull MUST Items: - MUST: rpmlint shows no error - MUST: dist tag is present - MUST: The package is named according to the Package Naming Guidelines. - MUST: The spec file name matching the base package libical, in the format libical.spec - MUST: This package meets the Packaging Guidelines. - MUST: The package is licensed with an open-source compatible license GPL. - MUST: License file COPYING is included in package. - MUST: The sources used to build the package matches the upstream source, as provided in the spec URL. md5sum is correct as 36c80c43940841e53e5a985204851c46. - MUST: This package owns all directories that it creates. - MUST: This package did not contain any duplicate files in the %files listing. - MUST: This package have a %clean section, which contains rm -rf $RPM_BUILD_ROOT. - MUST: This package used macros. - MUST: Document files are included like README.txt. - MUST: Package did NOT contained any .la libtool archives. - MUST: Header files are going in a -devel package. - MUST: Library files that end in .so (without suffix) are in a -devel package. - MUST: This package contains shared library files located in the dynamic linker's default paths, and therefore this package is calling ldconfig in %post and %postun. But Devel package is NOT calling a %post/%postun section that calls /sbin/ldconfig. * Source URL is present and working. * BuildRoot is correct BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * BuildRequires is correct * devel package contains the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review