Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ntop https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197198 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2006-07-05 17:30 EST ------- The perl substitutions are unusefull: the first one is allready done in a patch. The second operates on a file that is regenerated. I couldn't find 'user =' in the main.c file. It is in prefs.c however. I think that it should be replaced with a patch it is more robust than a substitution (it fails more easily). There is also a nobody in webInterface.c. Also maybe a comment could explain why other users are used. unix2dos may be replaced by sed -i 's/\r//' -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review