Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: connect-proxy - SSH Proxy command helper https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197716 ------- Additional Comments From pertusus@xxxxxxx 2006-07-05 18:14 EST ------- The %setup may be simplified as: %setup -q -T -c cp %{SOURCE0} connect.c %patch0 -p1 One rpmlint warning, not a big deal in my opinion (though I prefer spaces, since it looks the same in every editors): W: connect-proxy mixed-use-of-spaces-and-tabs The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. There are many warning durings compilation, some may be worrying. These are not blockers. Full review: * follow approximately naming guidelines, with a valid reason to deviate. * licence is GPL, not included since it is not included upstream * match upstream source b856937f1cdfca7a3ccfb2fac36ef726 ../SOURCES/connect-1.95.c * build on devel i386 * don't crash at start * remove $RPM_BUILD_ROOT in clean and install * right buildroot * %files right APPROVED I still think that having the html file located at the package URL would be a good idea. Not a blocker. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review