Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ibmasm https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193059 opensource@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@xxxxxxxxx ------- Additional Comments From opensource@xxxxxxxxx 2006-07-05 18:06 EST ------- - The Release-tag misses %{?dist}, e.g. Release: 6%{?dist} - The spec file does not use %{optflags}, so nothing is compiled with the typical flags of Fedora that include some security relevant flags. You can change this, e.g. with export CFLAGS="%{optflags}" prior to the first make and patch the Makefiles to make the compiler use CFLAGS - You need to run ldconfig since you install an .so file in /lib. - The License should be installed in the docdir and included in the upstream source package if it is not. Btw. you just need to wait until an official reviewer reviews your package and a Sponsor sponsers you. They will also tell you what else you need to change, if there is anything. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review