Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: connect-proxy - SSH Proxy command helper https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197716 ------- Additional Comments From pertusus@xxxxxxx 2006-07-05 17:35 EST ------- > I know the smp flags are useless in this case, but the guidelines suggest this > is a required field unless there is something blocking its use. It doesn't help, > but it also doesn't hurt, so nothing really blocks it from being in the spec. > Who knows, maybe some day the author refactors the code and they become useful. :) Ok, no problem here. > As for Source0... If I'm going to do anything to munge the name of the source, I > just assume put it into a tarball and clean up the messy %setup line (and remove > the line after it). Thoughts on that route versus just renaming the .c file? I think it is better to only rename the file since it is easier to verify that it is the right file. However if you prefer doing a tarball, do it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review