Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Locale-SubCountry https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197298 ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-07-03 16:05 EST ------- BuildRequires: perl is not necessary (not a blocker). It's not necessary to pass OPTIMIZE for a noarch package (not a blocker). Please add BR: perl(Test::Pod), perl(Test::Pod::Coverage) for complete test coverage. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * source files match upstream: b6d365e2db967821c2f1fdfcf064cab6 Locale-SubCountry-1.37.tar.gz * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: perl(Locale::SubCountry) = 1.37 perl(Locale::SubCountry::World) perl-Locale-SubCountry = 1.37-0.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Exporter) perl(locale) perl(strict) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. X %check is present but tests are skipped due to missing BuildRequires: All tests successful, 2 tests skipped. Files=3, Tests=15, 0 wallclock secs ( 0.10 cusr + 0.03 csys = 0.13 CPU) * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review