Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-shout https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181445 ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-07-03 13:43 EST ------- I have to agree; we should pick one thing and stick with it. However, unfortunately the PHP guidelines did not pass at the recent packaging committee meeting, so I cannot approve this package at this time no matter what happens to the guidelines. I will make sure that the ratified guidelines include the proper macros for extracting the PHP API version and the review this package against those. Honestly, my preference will be to avoid BS like "be_happy_mock" or hardcoding a specific default API version and just using "0". The only requirement is that the result after the macro expansions be a specfile with the proper syntax so that the initial BuildRequires can be extracted. It shouldn't even be necessary to play with the extdir define. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review