Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pyserial - Python serial port access library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191175 ------- Additional Comments From adam@xxxxxxxxxxxxx 2006-07-02 23:56 EST ------- rpmlint SRPM results: W: pyserial invalid-license PSF - see LICENSE.txt E: pyserial no-cleaning-of-buildroot * Please use "Python license" for License. * Don't forget "rm -rf $RPM_BUILD_ROOT" as the first step of %install. rpmlint RPM results: W: pyserial invalid-license PSF - see LICENSE.txt W: pyserial wrong-file-end-of-line-encoding /usr/share/doc/pyserial-2.2/CHANGES.txt E: pyserial wrong-script-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/wxTerminal.py W: pyserial wrong-file-end-of-line-encoding /usr/share/doc/pyserial-2.2/LICENSE.txt E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/serialposix.py 0644 E: pyserial wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/serial/serialposix.py E: pyserial wrong-script-interpreter /usr/lib/python2.4/site-packages/serial/serialwin32.py "python" E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/serialwin32.py 0644 E: pyserial wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/serial/serialwin32.py E: pyserial wrong-script-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/scan.py W: pyserial wrong-file-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/wxSerialConfigDialog.wxg E: pyserial wrong-script-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/miniterm.py E: pyserial wrong-script-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/test.py W: pyserial wrong-file-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/setup_demo.py E: pyserial wrong-script-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/tcp_serial_redirect.py E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/__init__.py 0644 E: pyserial wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/serial/__init__.py W: pyserial wrong-file-end-of-line-encoding /usr/share/doc/pyserial-2.2/README.txt E: pyserial wrong-script-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/test_advanced.py E: pyserial wrong-script-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/wxSerialConfigDialog.py E: pyserial wrong-script-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/test_high_load.py E: pyserial wrong-script-interpreter /usr/lib/python2.4/site-packages/serial/serialutil.py "python" E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/serialutil.py 0644 E: pyserial wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/serial/serialutil.py E: pyserial wrong-script-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/enhancedserial.py W: pyserial wrong-file-end-of-line-encoding /usr/share/doc/pyserial-2.2/examples/wxTerminal.wxg E: pyserial wrong-script-interpreter /usr/lib/python2.4/site-packages/serial/serialjava.py "jython" E: pyserial non-executable-script /usr/lib/python2.4/site-packages/serial/serialjava.py 0644 E: pyserial wrong-script-end-of-line-encoding /usr/lib/python2.4/site-packages/serial/serialjava.py * Most of the problems here are bad line endings. Perhaps you need to use a sed script or something to fix the endings on these files? * The other problem relates to the modules (.py files) having an interpreter line at the top. I suggest a patch to remove the #! lines from the top of each file. Also see: http://fedoraproject.org/wiki/Packaging/Python * In %description: do you mean "encapsulates" ? * You don't need Requires: python-abi ... * Include the .py and .pyc files only, but specify %ghost for the .pyo files I look forward to seeing your result ! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review