Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kdirstat https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196007 ------- Additional Comments From cgoorah@xxxxxxxxxxxx 2006-06-29 05:07 EST ------- (In reply to comment #6) > I don't like your dependency on /usr/share/doc/HTML/en/common; it might not work the way you expect. Your library dependencies will pull in kdelibs, which will provide that directory, so there's no need to depend on it. I did that to solve a dangling-symlink: W: kdirstat dangling-relative-symlink /usr/share/doc/HTML/en/kdirstat/common ../common The relative symbolic link points nowhere And I was just following a similar issue i've encountered before, https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193929#c15 Do you have a better solution for this ? > Technically you don't need to own /usr/share/apps/kconf_update either, because > kdelibs owns it, but most kde applications seem to own that directory so I don't see a problem with it. > here kconf_update contains fix_move_to_trash_bin.pl and kdirstat.upd perharps I should rather do %{_datadir}/apps/kconf_update/* instead of %{_datadir}/apps/kconf_update > You have post and postun requirements for desktop-file-utils but you don't call > desktop-file-install either in %post or %postun. You should just remove them. > I've dropped them. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review