Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-PerlIO-eol - PerlIO layer for normalizing line endings https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196622 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-06-28 20:58 EST ------- Note that BuildRequires: perl is redundant; it is in the default build root. The version requirement is satisfied on all platforms that Extras supports so it's safe to leave it out. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * source files match upstream: 7e11fb1cc3b2a65678714877ae361823 PerlIO-eol-0.13.tar.gz * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: eol.so()(64bit) perl(PerlIO::eol) = 0.13 perl-PerlIO-eol = 0.13-3.fc6 = perl >= 0:5.007003 perl(:MODULE_COMPAT_5.8.8) perl(Exporter) perl(XSLoader) * shared libraries are present, internal to Perl. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass: All tests successful. Files=1, Tests=23, 0 wallclock secs ( 0.02 cusr + 0.01 csys = 0.03 CPU) * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review