Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-IO-Digest - Perl module to calculate digests while reading or writing https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196621 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |tibbs@xxxxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-06-28 20:29 EST ------- I cannot fetch the spec via that URL. I can get the srpm fine, however. You have a duplicated dependency on PerlIO::via::dynamic. Since you've just packaged this, I think it safe to say that the necessary version is in Extras and the dependency can be dropped. Otherwise you'll need to filter. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * source files match upstream: 0448841e0559c2c19c7e8001ef087e26 IO-Digest-0.10.tar.gz * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). * rpmlint is silent. X a duplicated dependency: perl(IO::Digest) = 0.10 perl-IO-Digest = 0.10-3.fc6 = perl >= 0:5.008 perl(:MODULE_COMPAT_5.8.8) perl(Digest) X perl(PerlIO::via::dynamic) X perl(PerlIO::via::dynamic) >= 0.10 perl(strict) perl(warnings) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass: All tests successful. Files=2, Tests=4, 0 wallclock secs ( 0.04 cusr + 0.04 csys = 0.08 CPU) * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review