Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: koan https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192313 ------- Additional Comments From mdehaan@xxxxxxxxxx 2006-06-28 18:06 EST ------- All rpmlint errors have been fixed and the packages have been updated at the above URLs. Please let me know if there's anything else that needs to be fixed. === The three macros at the top of the file are totally redundant. * Don't see this being a problem. Correct me if it breaks something. 2) Remove Vendor tag. * Fixed 3) Relaease should contain the dist tag * Fixed, per instructions on http://fedoraproject.org/wiki/DistTag ... please verify I got this right, though. As I understand it, my RPM's won't show any dist in the name until the build system tries to build them. 4) The Prefix tag seems redundant ( I may be missing something there tho). * Fixed (Removed) 5) the install section should begin with rm -rf $RPM_BUILD_ROOT * Fixed -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review