Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libhugetlbfs - easy access to huge pages of memory https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196057 ------- Additional Comments From jwilson@xxxxxxxxxx 2006-06-28 11:24 EST ------- (In reply to comment #18) > Full review of requirements checklist: > * build root is correct -- almost, but not quite, should be %{version} in there instead of % > {libhugetlbfs_version} Good to go. > * BuildRequires are proper -- need to remove /usr/include/gnu/stubs-32.h Good to go. > * rpmlint is silent -- not quite: > W: libhugetlbfs no-soname /usr/lib64/libhugetlbfs.so > E: libhugetlbfs script-without-shellbang /usr/share/libhugetlbfs/ldscripts/elf_x86_64.xB > E: libhugetlbfs script-without-shellbang /usr/share/libhugetlbfs/ldscripts/elf_x86_64.xBDT > > The first isn't a problem, the 2nd and 3rd we can get rid of by chmod -x'ing the ldscripts. (I'm > assuming they don't need to be executable). Okay, those are taken care of, but I screwed up and forgot to mention one other than I'd manually adjusted in a local copy of the spec. The version in the changelog should be 0.20060627-1 instead of 0:20060627-1 (rpmlint complains about a bad revision or some such thing). > * owns the directories it creates -- missing a '%dir %{_datadir}/libhugetlbfs' for the base package Good to go. Once the version in the changelog is corrected, I believe the package is ready for Extrafication (pending sponsorship, of course). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review