Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: aiccu https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189705 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-06-28 02:04 EST ------- A few comments: As in comment #2, Source0 is not a full URL. I suggest using: Source0: http://www.sixxs.net/archive/sixxs/aiccu/unix/aiccu_%{version}.tar.gz Builds fine in mock; rpmlint says: E: aiccu non-readable /etc/aiccu.conf 0600 Understandable since this includes password information. W: aiccu service-default-enabled /etc/init.d/aiccu The init script has: # chkconfig: 345 15 85 So the service will start enabled in runlevels 3, 4, and 5. You should s/345/-/. The makefile strips the binary, which breaks -debuginfo generation. Other than those, things look pretty good although I suspect that once you fix -debuginfo generation, the fact that many of the source files are executable for some reason will cause several other warnings. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review