Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Net-Socket Alias: php-pear-Net-Socket https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190957 ------- Additional Comments From chris.stone@xxxxxxxxx 2006-06-27 18:32 EST ------- MUST ITEM CHECKLIST: - rpmlint output: W: php-pear-Net-Socket invalid-license PHP License W: php-pear-Net-Socket dangerous-command-in-%post install W: php-pear-Net-Socket invalid-license PHP License Warnings can be ignored - package is named according to php packaging naming guidelines - spec file name matches %{name} - package meets packaging guidelines - package is licensed with open source compatible license - license field matches actual license - source contains license file in %doc - spec file is in American English (and french) - spec file is legible - sources match upstream f961deffb093a58eb4c48478de1b27ed Net_Socket-1.0.6.tgz - package successfully compiles and builds on FC-5 x86_64 O This package is missing: Requires(post): php-pear >= 1.4.9 Requires(postun): php-pear >= 1.4.9 - package does not use locales - package does not contain shared libraries in default paths (no need to run ldconfig) - package is not relocatable - package does not own all directories it creates It does not own the /usr/share/pear/Net directory. - package does not contain any duplicate %files - permissions are set properly - package contains proper %clean section - macro usage is consistant - package contains permissible content - package does not have large documentation - package does not include header files or static libraries - package does not use pkgconfig files - package does not contain library with suffix - package does not require a devel subpackage - package does not contain any .la files - package is not a gui and does not need a .desktop file - package does not own files or directories owned by other packages This may change in future. MUST - Must own the /usr/share/pear/Net directory add a %dir %{peardir}/Net - Must Add: Requires(post): php-pear >= 1.4.9 Requires(postun): php-pear >= 1.4.9 - Explain why adding || : in %post and %postun sections was added, should we not fail if this step fails? - Change %defattr to (-,root,root,-) - Remove dist tages in changelog version numbers -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review