Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: coldet - 3D Collision Detection Library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196710 ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-06-26 15:38 EST ------- (In reply to comment #1) > The *-devel packages installs its headers to /usr/include, resulting into this: > /usr/include/coldet.h > /usr/include/math3d.h > > To me, /usr/include/math3d.h is too general to justify installing it there[1]. > I strongly recommend to install the headers into /usr/include/coldet instead. > I was thinking this at first too, then I though it would be ok and that if it wouldn't be ok I would hear so during the review :) > Also, the package suffers from quite an amount of rather serious GCC warnings > (esp. punned pointers), which are not unlikely to break its functionality. > Huh, quite an amount? on x86_64 devel I count 3 "dereferencing type-punned pointer will break strict-aliasing rules" warnings. I've once spend a days fixing all those warnings in Glide3. But I've given up there are simple to many of these warnings and 99.9% is not a problem. I know howto fix these, but I don't see how this package is any different from all the other packages we have with these kind of warnings. Here is a new version soon moving the headers to /usr/include/coldet: Spec URL: http://people.atrpms.net/~hdegoede/coldet.spec SRPM URL: http://people.atrpms.net/~hdegoede/coldet-1.1-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review