[Bug 188359] Review Request: bugzilla - bug tracking tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bugzilla - bug tracking tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188359


tibbs@xxxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs@xxxxxxxxxxx  2006-06-26 10:40 EST -------
OK, everything's looking good.  But I did turn up a few issues wieh working
through my checklist.

First off, the spec says GPL but it doesn't look like it to me.  The first file
I checked clearly says "Mozilla Public License" and the FAQ I found with a quick
search seems to back this up.  So s/GPL/MPL/.  In addition, there doesn't seem
to be an actual copy of the license included; upstream should be bugged about
this but I believe they're listening.

Also, there are files like README and QUICKSTART which are marked as %doc but
which get installed under /usr/share/bugzilla instead of
/usr/share/doc/bugzilla-2.22 as I'd expect.  I think that when you mark packages
as %doc that are already installed they don't get moved under docdir.  I don't
think this is a blocker but you might want to have a look.

Finally, I'm pretty sure there will be selinux problems with this package. 
Unfortunately I have no real way to test it at the moment, and I don't think
selinux issues are blockers right now.  But I do suggest you work with the
selinux folks and possibly Paul Howarth, who has been doing a bunch of work on
packaging selinux rules.

rpmlint says:
W: bugzilla-contrib no-documentation
W: bugzilla-doc no-documentation
both of which are fine.

Since the only required change is G->M in the License: tag, I'll go ahead and
approve this so we can put it to bed.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
X license field matches the actual license.
* license is open source-compatible.  License text not included upstream. 
* source files match upstream:
   bbf2f1ec5607978d39855df104231973  bugzilla-2.22.tar.gz
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
O rpmlint is silent.
* final provides and requires are sane (see full list at end)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present; no test suite upstream.
* scriptlets are present and OK (%post script to generate default setup)
* code, not content.
* large documentation is in a -doc subpackage
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

Full dependency list:
bugzilla-2.22-4.fc6.noarch.rpm
 config(bugzilla) = 2.22-4.fc6
 perl(Bugzilla)
 perl(Bugzilla::Attachment)
 perl(Bugzilla::Auth)
 perl(Bugzilla::Auth::Login::WWW)
 perl(Bugzilla::Auth::Login::WWW::CGI)
 perl(Bugzilla::Auth::Login::WWW::CGI::Cookie)
 perl(Bugzilla::Auth::Login::WWW::Env)
 perl(Bugzilla::Auth::Verify::DB)
 perl(Bugzilla::Auth::Verify::LDAP)
 perl(Bugzilla::Bug)
 perl(Bugzilla::BugMail)
 perl(Bugzilla::CGI)
 perl(Bugzilla::Chart)
 perl(Bugzilla::Classification)
 perl(Bugzilla::Component)
 perl(Bugzilla::Config)
 perl(Bugzilla::Config::Admin)
 perl(Bugzilla::Config::Attachment)
 perl(Bugzilla::Config::Auth)
 perl(Bugzilla::Config::BugChange)
 perl(Bugzilla::Config::BugFields)
 perl(Bugzilla::Config::BugMove)
 perl(Bugzilla::Config::Common)
 perl(Bugzilla::Config::Core)
 perl(Bugzilla::Config::DependencyGraph)
 perl(Bugzilla::Config::GroupSecurity)
 perl(Bugzilla::Config::L10n)
 perl(Bugzilla::Config::LDAP)
 perl(Bugzilla::Config::MTA)
 perl(Bugzilla::Config::PatchViewer)
 perl(Bugzilla::Config::Query)
 perl(Bugzilla::Config::ShadowDB)
 perl(Bugzilla::Config::UserMatch)
 perl(Bugzilla::Constants)
 perl(Bugzilla::DB)
 perl(Bugzilla::DB::Mysql)
 perl(Bugzilla::DB::Pg)
 perl(Bugzilla::DB::Schema)
 perl(Bugzilla::DB::Schema::Mysql)
 perl(Bugzilla::DB::Schema::Pg)
 perl(Bugzilla::Error)
 perl(Bugzilla::Field)
 perl(Bugzilla::Flag)
 perl(Bugzilla::FlagType)
 perl(Bugzilla::Group)
 perl(Bugzilla::Milestone)
 perl(Bugzilla::Product)
 perl(Bugzilla::Search)
 perl(Bugzilla::Search::Quicksearch)
 perl(Bugzilla::Series)
 perl(Bugzilla::Template)
 perl(Bugzilla::Template::Plugin::Bugzilla)
 perl(Bugzilla::Template::Plugin::Hook)
 perl(Bugzilla::Template::Plugin::User)
 perl(Bugzilla::Token)
 perl(Bugzilla::User)
 perl(Bugzilla::User::Setting)
 perl(Bugzilla::Util)
 perl(Bugzilla::Version)
 perl(Support::Files)
 perl(Support::Systemexec)
 perl(Support::Templates)
 bugzilla = 2.22-4.fc6
=
 /bin/sh
 /usr/bin/perl
 config(bugzilla) = 2.22-4.fc6
 graphviz
 patchutils
 perl(AnyDBM_File)
 perl(Bugzilla)
 perl(Bugzilla::Attachment)
 perl(Bugzilla::Auth)
 perl(Bugzilla::Auth::Login::WWW)
 perl(Bugzilla::Bug)
 perl(Bugzilla::BugMail)
 perl(Bugzilla::CGI)
 perl(Bugzilla::Chart)
 perl(Bugzilla::Classification)
 perl(Bugzilla::Component)
 perl(Bugzilla::Config)
 perl(Bugzilla::Config::Common)
 perl(Bugzilla::Constants)
 perl(Bugzilla::DB)
 perl(Bugzilla::DB::Schema)
 perl(Bugzilla::Error)
 perl(Bugzilla::Field)
 perl(Bugzilla::Flag)
 perl(Bugzilla::FlagType)
 perl(Bugzilla::Group)
 perl(Bugzilla::Milestone)
 perl(Bugzilla::Product)
 perl(Bugzilla::Search)
 perl(Bugzilla::Search::Quicksearch)
 perl(Bugzilla::Series)
 perl(Bugzilla::Template)
 perl(Bugzilla::Token)
 perl(Bugzilla::User)
 perl(Bugzilla::User::Setting)
 perl(Bugzilla::Util)
 perl(Bugzilla::Version)
 perl(CGI)
 perl(CGI::Carp)
 perl(DBD::Pg)
 perl(DBI)
 perl(Data::Dumper)
 perl(Date::Format)
 perl(Date::Parse)
 perl(Errno)
 perl(Exporter)
 perl(Fcntl)
 perl(File::Basename)
 perl(File::Find)
 perl(File::Spec)
 perl(File::Temp)
 perl(Getopt::Long)
 perl(IO::Handle)
 perl(MIME::Base64)
 perl(MIME::Parser)
 perl(MIME::QuotedPrint)
 perl(Mail::Address)
 perl(Mail::Header)
 perl(Mail::Mailer)
 perl(Net::LDAP)
 perl(Pod::Usage)
 perl(Safe)
 perl(Socket)
 perl(Storable)
 perl(Support::Files)
 perl(Template::Stash)
 perl(Test::Harness)
 perl(Text::Wrap)
 perl(XML::Twig)
 perl(base)
 perl(constant)
 perl(diagnostics)
 perl(lib)
 perl(strict)
 perl(vars)
 smtpdaemon
 webserver

bugzilla-contrib-2.22-4.fc6.noarch.rpm
 bugzilla-contrib = 2.22-4.fc6
=
 /bin/sh
 /usr/bin/env
 /usr/bin/perl
 /usr/bin/python
 /usr/bin/ruby
 perl(Bugzilla)
 perl(Bugzilla::BugMail)
 perl(Bugzilla::Config)
 perl(Bugzilla::Constants)
 perl(Bugzilla::DB)
 perl(Bugzilla::User)
 perl(Bugzilla::Util)
 perl(BugzillaEmail)
 perl(Getopt::Long)
 perl(MIME::Parser)
 perl(Net::LDAP)
 perl(Pod::Usage)
 perl(constant)
 perl(lib)
 perl(strict)

bugzilla-doc-2.22-4.fc6.noarch.rpm
 bugzilla-doc = 2.22-4.fc6
=
 /usr/bin/perl
 perl(File::Basename)
 perl(diagnostics)
 perl(strict)

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]