Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: iksemel - An XML parser library designed for Jabber applications https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193493 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |tibbs@xxxxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-06-26 00:33 EST ------- I noticed the following build failure: + aclocal aclocal:configure.ac:14: warning: macro `AM_PROG_LIBTOOL' not found in library which is solved by adding BuildRequires: libtool. However, I'm not sure why you think you need to rerun the autotools. You can disable rpath just by using make LIBTOOL=/usr/bin/libtool %{?_smp_mflags} and then deleting the extra .a file that shows up. Other than that, the package looks good and rpmlint is completely silent. There is, however, a test suite that you should call (with "make check") in a %check section. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * source files match upstream: 82e7c8fdb6211839246b788c040a796b iksemel-1.2.tar.gz * latest version is being packaged. X BuildRequires are proper (libtool, as above) * package builds in mock (development, x86_64) (after fixing libtool) * rpmlint is silent. * final provides and requires are sane: iksemel-1.2-2.fc6.x86_64.rpm libiksemel.so.3()(64bit) iksemel = 1.2-2.fc6 = /sbin/ldconfig libiksemel.so.3()(64bit) iksemel-devel-1.2-2.fc6.x86_64.rpm iksemel-devel = 1.2-2.fc6 = /bin/sh /sbin/install-info gnutls-devel iksemel = 1.2-2.fc6 libiksemel.so.3()(64bit) pkgconfig iksemel-utils-1.2-2.fc6.x86_64.rpm iksemel-utils = 1.2-2.fc6 = iksemel = 1.2-2.fc6 libiksemel.so.3()(64bit) * shared libraries are present; ldconfig is called properly and the unversioned .so is in the -devel subpackage. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. X %check is not present but there is a test suite. * scriptlets present and OK (ldconfig, install-info) * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * headers present, in -devel package. * pkgconfig files present, in -devel package and pkgconfig is required. * no libtool .la droppings. * not a GUI app. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review