Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Calendar-Simple - Perl extension to create simple calendars https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196403 paul@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |paul@xxxxxxxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From paul@xxxxxxxxxxxx 2006-06-23 05:38 EST ------- Review: - rpmlint clean - package and spec naming OK - package meets guidelines - license is same as perl, matches spec - spec file written in English and is legible - sources match upstream - package builds ok in mock (devel i386) - BR's OK - no locales, libraries, subpackages, or pkgconfigs to worry about - no relocatable - no dorectory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code not content - no large docs, docs don't affect runtime - not a GUI app, no desktop file needed - no scriptlets The only small cosmetic nit is that the rpm tag values seems to be misaligned (I tried tab stops of 4 and 8, and neither were pretty) Approved. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review