Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libhugetlbfs - easy access to huge pages of memory https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196057 ------- Additional Comments From jwilson@xxxxxxxxxx 2006-06-20 15:02 EST ------- I'll just go ahead and start compiling notes... 1) I'd make the version be 0.20060619, so that in the event the package switches to a 1.x, 2.x versioning scheme, you don't have to introduce epochs to make upgrades smooth. (You'd just have to have the first non-date-versioned package be like 0.3 or higher). 2) You have an empty %doc line in the %files section of the base package... If there are no docs, remove the line, if there are docs, list 'em. :) 3) In the -devel subpackage, you're including static libs. Are these necessary for proper usage? Typically, static libs are frowned upon in Fedora packages. 4) The package is failing to build in a mock fc5/i386 chroot as well as the build failures on fc5/x86_64 (see below). Does the package try to ascertain some information about the system its building on from 'uname -m', by chance? I'm assuming the objs64 stuff shouldn't be trying to build on i386. Building target platforms: i386 Building for target i386 Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.26150 + umask 022 + cd /builddir/build/BUILD + LANG=C + export LANG + unset DISPLAY + cd /builddir/build/BUILD + rm -rf libhugetlbfs-20060619 + /bin/gzip -dc /builddir/build/SOURCES/libhugetlbfs-20060619.tar.gz + tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + cd libhugetlbfs-20060619 + exit 0 Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.26150 + umask 022 + cd /builddir/build/BUILD + cd libhugetlbfs-20060619 + LANG=C + export LANG + unset DISPLAY + make -j4 CC32 obj32/hugeutils.o CC32 obj32/elflink.o CC32 obj32/morecore.o CC32 obj32/debug.o hugeutils.c: In function 'hugetlbfs_shared_file': hugeutils.c:369: warning: cast from pointer to integer of different size elflink.c:71:2: warning: #warning __syscall_return macro not available. Some debugging will be disabled during executable remapping CC64 obj64/hugeutils.o CC64 obj64/elflink.o elflink.c:1: sorry, unimplemented: 64-bit mode not compiled in hugeutils.c:1: sorry, unimplemented: 64-bit mode not compiled in CC64 obj64/morecore.o morecore.c:1: sorry, unimplemented: 64-bit mode not compiled in elflink.c:71:2: warning: #warning __syscall_return macro not available. Some debugging will be disabled during executable remapping hugeutils.c: In function 'hugetlbfs_shared_file': hugeutils.c:369: warning: cast from pointer to integer of different size make: *** [obj64/elflink.o] Error 1 make: *** Waiting for unfinished jobs.... make: *** [obj64/hugeutils.o] Error 1 make: *** [obj64/morecore.o] Error 1 error: Bad exit status from /var/tmp/rpm-tmp.26150 (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.26150 (%build) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review