Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Kmenu-gnome https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196003 ------- Additional Comments From panemade@xxxxxxxxx 2006-06-20 07:56 EST ------- Ok let me try to solve rpmlint errors for you. >rpmlint -i complains: >chitlesh(i386)[0]$rpmlint -i kmenu-gnome-0.5-1.i386.rpm >E: kmenu-gnome no-binary >The package should be of the noarch architecture because it doesn't contain >any binaries. Then you can add to SPEC file BuildArchitectures: noarch >E: kmenu-gnome standard-dir-owned-by-package /usr/share >This package owns a directory that is part of the standard hierarchy, which >can lead to default directory permissions or ownerships being changed to >something non-standard. >E: kmenu-gnome standard-dir-owned-by-package /usr >This package owns a directory that is part of the standard hierarchy, which >can lead to default directory permissions or ownerships being changed to >something non-standard. >E: kmenu-gnome standard-dir-owned-by-package /etc >This package owns a directory that is part of the standard hierarchy, which >can lead to default directory permissions or ownerships being changed to >something non-standard. >E: kmenu-gnome standard-dir-owned-by-package /usr/share/icons >This package owns a directory that is part of the standard hierarchy, which >can lead to default directory permissions or ownerships being changed to >something non-standard. You should not make Systems standard direcory's to belong to your package. thats what i ask you to add only those files that are installed by your package. W: kmenu-gnome non-conffile-in-etc /etc/xdg/menus/applications-merged/kmenu-gnome.menu A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. under %files section you can add %config /etc/xdg/menus/applications-merged/kmenu-gnome.menu W: kmenu-gnome dangerous-command-in-%post rm W: kmenu-gnome dangerous-command-in-%preun rm why the patch is needed to apply at post routine?? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review