Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 ------- Additional Comments From sander@xxxxxxxxxxx 2006-06-20 03:30 EST ------- (In reply to comment #31) > (In reply to comment #27) > > (In reply to comment #25) > > > > > * Missing "Requires: mozilla". I would recommend, however, changing the > > > default browser command from 'mozilla $url' to 'htmlview $url' and > > > adding "Requires: htmlview". This will launch the url in the > > > user's preferred web browser. > > I changed mozilla to htmlview but I am not sure about requiring it. aMSN runs > > fine without it, only when you try to open an url it tells you you should check > > your preferences. People not having htmlview have chosen for that i guess, since > > it is installed by default. > > I still think you should add "Requires: htmlview, sox". If the application > uses it, it should be in the Requires: list. Even though htmlview is > installed by default, it's best to make sure that the package has it > available. Fortunately, amsn won't crash if it's not there, it will just > print out a warning that the user needs to modify their configuration. > I don't think the additional Requires: will hurt anything. > Ok, in the past I have been pissed off when i wanted to remove something, and it pulled in lots of other stuff which I didn't see the point in. I added the requires for sox, htmlview and tkdnd (since that seems to fall in the same category, without it drag and drop doesn't work) > > Are there plans to make the RC1 release public? It'd be really nice to have a > working Source0: link in the spec file that points to SF. Right now I can't get > to it using curl, wget, or a browser. Yes there are plans, but we want all packages created first, and synced to mirrors. In the meanwhile go to: http://prdownloads.sourceforge.net/amsn/amsn-0.96rc1.tar.bz2?download since what is in Source0 should work, but doesn't because of sf slowness I think. > > > * Is there a special reason why the amsn commands (amsn, amsn-remote, > > > amsn-remote-CLI) are located in %{_datadir}/amsn and only linked to > > > %{_bindir}? Why can't they just be installed directly into %{_bindir}? > > Yes, the file perform some magic to see where they are located, and set some > > variables accordingly to be able to find plugins etc. > > Ok. That makes sense. You might suggest to upstream :) that they validate > $program_dir before trying to resolve symlinks. This would allow you to use sed > in the spec file to set program_dir to %{_datadir}/%{name} and bypass the > symlink dereferencing in the program. As a result, the program should still > work as it does now, but it would also work if amsn weren't installed in the > data directory. No changes were needed, after some looking at the code I could do it with one sed line in the spec > > A few other items: > > MUSTFIX > ======= > * Remove the extra " from the comment in the .desktop file ok, did it in the spec and upstream as well > * It turns out that /usr/share/amsn/README is needed at runtime for the > About box. You can go ahead and remove it from the list of doc files > that are deleted during %install. Do you know of any other doc files > that are used at runtime? Only HELP, which you mention below and CREDITS, which I now don't delete as well > > SHOULD > ====== > * The Help -> Contents menu item doesn't seem very useful, since it > describes how to install and start amsn, which the user must have > already done if they can activate the menu. I'd suggest to upstream that > they either remove this menu item, or replace the Help ->Contents text with > something more useful. Ok, I told upstream :) and they told me it will be fixed before next release. Good catch, I guess we never read the help documents ourselves.. http://amsn.hoentjen.eu/download/amsn.spec http://amsn.hoentjen.eu/download/amsn-0.96-0.11.rc1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review