Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: poedit - GUI editor for GNU gettext .po files https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192884 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-06-20 02:51 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (MIT) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: e76a84ae4be4ad9d9a176fd8a1a2effb poedit-1.3.4.tar.gz e76a84ae4be4ad9d9a176fd8a1a2effb poedit-1.3.4.tar.gz.1 OK - Package compiles and builds on at least one arch. n/a - Package needs ExcludeArch OK - BuildRequires correct OK - Spec handles locales/find_lang n/a - Spec has needed ldconfig in post and postun n/a - Package is relocatable and has a reason to be. OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. n/a - -doc subpackage needed/used. OK - Packages %doc files don't affect runtime. n/a - Headers/static libs in -devel subpackage. n/a - .pc files in -devel subpackage. n/a - .so files in -devel subpackage. n/a - -devel package Requires: %{name} = %{version}-%{release} n/a - .la files are removed. OK - Package is a GUI app and has a .desktop file OK - Package doesn't own any directories other packages own. See below - No rpmlint output. Issues: 1. Some rpmlint output: Not sure if it's worth fixing these with sed/dos2unix/perl or just reporting it upstream: W: poedit wrong-file-end-of-line-encoding /usr/share/doc/poedit-1.3.4/en/gettext.hhp W: poedit wrong-file-end-of-line-encoding /usr/share/doc/poedit-1.3.4/en/gettext.hhc W: poedit wrong-file-end-of-line-encoding /usr/share/doc/poedit-1.3.4/en/poedit.hhc W: poedit wrong-file-end-of-line-encoding /usr/share/doc/poedit-1.3.4/en/poedit.hhp These are likely locales that rpmlint doesn't know about/are nonstandard? E: poedit incorrect-locale-subdir /usr/share/locale/ast/LC_MESSAGES/poedit.mo E: poedit incorrect-locale-subdir /usr/share/locale/fur/LC_MESSAGES/poedit.mo 2. I did a mock build for fc5 and that worked fine. Given the above comments I also did a rpmbuild --rebuild on both a fc5 and devel machine and those both worked just fine as well, everything seems to build as expected in both mock/non mock env's. 3. There are lots of warnings when building, like: /usr/include/wx-2.6/wx/clntdata.h:31: warning: dereferencing type-punned pointer will break strict-aliasing rules Might be worth reporting upstream. None of the above are blockers, so this package is APPROVED. remember to close this bug with NEXTRELEASE after it's imported and built. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review