Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tcpick https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195764 ------- Additional Comments From jwilson@xxxxxxxxxx 2006-06-19 23:12 EST ------- Just parroting from http://fedoraproject.org/wiki/Packaging/Guidelines on the %makeinstall bit. :) Also, how about using '%configure --bindir=%{_sbindir}' instead of using an extra line to move the file? Not a requirement, but results in at least one less line in the spec. Now for the rest of the review: * package meets naming and packaging guidelines -- okay * specfile is properly named, is cleanly written and uses macros consistently -- okay * dist tag is present -- okay * build root is correct -- okay %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * license field matches the actual license -- GPL, okay * license is open source-compatible and license text included in package -- okay * source files match upstream -- okay bb94f2f9ea81aeb645619fbe9b3b9a29 tcpick-0.2.1.tar.gz * latest version is being packaged -- 0.2.1, okay * BuildRequires are proper -- okay * package builds in mock -- okay (fedora development x86_64) * rpmlint is silent -- okay * final provides and requires are sane -- okay tcpick-0.2.1-8.fc6.x86_64.rpm tcpick = 0.2.1-8.fc6 = libpcap.so.0.9.4()(64bit) * no shared libraries are present -- okay * package is not relocatable -- okay * owns the directories it creates -- okay * doesn't own any directories it shouldn't -- okay * no duplicates in %files -- okay * file permissions are appropriate -- okay * %clean is present -- okay * %check is present and all tests pass -- n/a (include the summary from the test suite, if any) * no scriptlets present -- okay * code, not content -- okay * documentation is small, so no -docs subpackage is necessary -- okay * %docs are not necessary for the proper functioning of the package -- okay * no headers -- okay * no pkgconfig files -- okay * no libtool .la droppings -- okay * not a GUI app -- okay * not a web app -- okay Only thing I see that needs to be altered to comply with the packaging guidelines is the use of % makeinstall. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review