Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: CastPodder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195394 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-06-19 17:35 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 58e0e76774eae0374a3c593e6bdc319d CastPodder-5.0.tar.bz2 58e0e76774eae0374a3c593e6bdc319d CastPodder-5.0.tar.bz2.1 - Package compiles and builds on at least one arch. n/a - Package needs ExcludeArch - BuildRequires correct n/a - Spec handles locales/find_lang n/a - Spec has needed ldconfig in post and postun n/a - Package is relocatable and has a reason to be. OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. n/a - -doc subpackage needed/used. OK - Packages %doc files don't affect runtime. n/a - Headers/static libs in -devel subpackage. n/a - .pc files in -devel subpackage. n/a - .so files in -devel subpackage. n/a - -devel package Requires: %{name} = %{version}-%{release} n/a - .la files are removed. See Below - Package is a GUI app and has a .desktop file OK - Package doesn't own any directories other packages own. See below - No rpmlint output. Issues: 1. Why install in /opt? (I guess because upstream does?) IMHO /opt is for locally installed optional applications, not packages from Fedora. Can you change it to install those files in /usr/share/${name}/ instead? 2. This %pre is very dangerous and not needed: %pre # lets make sure nothing is there so we delete the old # directory first before installing - sgrayban rm -fr /opt/%{name} rpm should handle removing files on install/upgrade. 3. Should this be a noarch package? (ie BuildArch: noarch)? 4. Should use a proper 'desktop-file-install' with a BuildRequires: desktop-file-utils to install the desktop file instead of a install... http://fedoraproject.org/wiki/Packaging/Guidelines#desktop Might be nice to include the desktop file as another SOURCE too. 5. Some macros seem to not be defined in fedora. building under mock fails with: RPM build errors: File must begin with "/": %_menudir/CastPodder File must begin with "/": %_iconsdir/CastPodder.png File must begin with "/": %_liconsdir/CastPodder.png 6. Since I can't get it to build, no rpmlint output yet, but running rpmlint on the provided rpm from the site gives a number of things that should be dealt with: Should remove the libxml2-python Requires? E: CastPodder explicit-lib-dependency libxml2-python explicit-lib-dependency : You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. Perhaps pick "Applications/Multimedia" ? W: CastPodder non-standard-group Networking/News Shouldn't have the Obsoletes: iPodder when this package provides it. E: CastPodder obsolete-on-name obsolete-on-name : A package should not obsolete itself, as it can cause weird errors in tools. E: CastPodder obsolete-not-provided iPodder obsolete-not-provided : The obsoleted package must also be provided to allow clean upgrade paths and not to break dependencies. E: CastPodder dir-or-file-in-opt /opt/CastPodder/localization/catalog/ga.py dir-or-file-in-opt : A file in the package is located in /opt. It's not permitted for packages to install files in this directory. E: CastPodder wrong-script-interpreter /opt/CastPodder/localization/catalog/ga.py "python" ... (tons of repeats on those) Should remove the %pre command: W: CastPodder dangerous-command-in-%pre rm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review