Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tetex-fonts-hebrew https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195585 ------- Additional Comments From danken@xxxxxxxxxxxxxxxxx 2006-06-19 16:50 EST ------- Thanks for the detailed and helpful review. > I think you're missing a BuildRequires: tetex. tetex-afm does not > pull it in. I think this points to a missing BuildRequires: > fonts-hebrew. I still get: Indeed, I implicitly expected that both tetex and fonts-hebrew are there on build time. > ./mkCLMtfm.sh rm: cannot remove `culmus.map': No such file or > directory I eliminated this error by replacing the rm with a cp of /dev/null > and a bunch of "I had to round some hights by X units" but it looks > like the package builds OK now. I don't know what is this LaTeX problem. I hope to have some Hebrew support, it does not have to be flawless. > without the BR: fonts-hebrew; you might want to add some > error-checking somewhere.) Maybe I should, but I don't know what and how. Checking whether the number of generated files is nonzero sounds very silly... > Can you verify that you are the upstream for the source tarball? > Generally your Source: tag includes a URL to the upstream source, > but it's possible that for a package like this the package is the > upstream source. I'm going to assume that there is no upstream > source here. Indeed, I am the one packing the tarball. Note however, that this package is a (simple) repackaging of the Culmus fonts for the use of tetex. > Once built, rpmlint has this to say: W: tetex-fonts-hebrew > incoherent-version-in-changelog 0.1-1 0.1-2.fc6 > > You don't seem to have added a changelog entry for what went into > release 2. You got me. > Absolute symlinks aren't OK; these should be relative (a blocker). Should I use ../../share/fonts/hebrew instead? > You have various scriptlets which call texhash and updmap-sys but > you don't specify appropriate requirements for them: > > Requires(post): tetex (or /usr/bin/texhash) (updmap-sys comes from > tetex-fonts which is a dependency of tetex; it should be OK to leave > it out but you're free to be more explicit if you like) > Requires(preun): tetex-fonts (or /usr/bin/updmap-sys) > > (the postun requirement on /usr/bin/texhash is picked up by rpm > automatically) I should be RTFMing about it, but are my scriptlets sane? I would like to run texhash after any change to the TeX tree, and updmap-sys if culmus.map is added (or going to be removed). Would you take a look? > This package doesn't seem to own > /usr/share/texmf/fonts/tfm/public/culmus and > /usr/share/texmf/fonts/vf/public/culmus/, and nothing else in the > repository seems to either. (/usr/share/texmf/fonts/tfm/public and > /usr/share/texmf/fonts/vf/public are owned by tetex-fonts which is > in the dependency tree). I hope this is solved by adding the directories explicitly to the file list. Please see the update SRPM at http://ivrix.org.il/redhat/tetex-fonts-hebrew-0.1-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review