Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: imlib https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194355 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-06-19 16:27 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (LGPL) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 8ab3f6ea596f731d54c18385bcc3525f imlib-1.9.13.tar.gz 8ab3f6ea596f731d54c18385bcc3525f imlib-1.9.13.tar.gz.1 See below - Package compiles and builds on at least one arch. n/a - Package needs ExcludeArch OK - BuildRequires correct n/a - Spec handles locales/find_lang OK - Spec has needed ldconfig in post and postun n/a - Package is relocatable and has a reason to be. OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. n/a - -doc subpackage needed/used. OK - Packages %doc files don't affect runtime. OK - Headers/static libs in -devel subpackage. OK - .pc files in -devel subpackage. OK - .so files in -devel subpackage. OK - -devel package Requires: %{name} = %{version}-%{release} n/a - .la files are removed. n/a - Package is a GUI app and has a .desktop file n/a - Package doesn't own any directories other packages own. See below - No rpmlint output. Issues: 1. Source: URL isn't right. Perhaps it should be: http://ftp.gnome.org/pub/GNOME/sources/imlib/1.9/imlib-%{version}.tar.gz 2. 1.9.15 is the current version, should upgrade? Might reduce the patches as well since there is a comment about backported fixes from 1.9.14. 3. URL: perhaps should be http://www.enlightenment.org/Libraries/Imlib.html ? 4. Should include the LGPL from COPYING.LIB 5. Building with mock for fc5, the build fails and I get: ... gcc -DDJPEG_PROG=\"/usr/bin/djpeg\" -DCJPEG_PROG=\"/usr/bin/cjpeg\" -DCONVERT_PATH=\"\" -DNETPBM_PATH=\"\" -DSYSTEM_IMRC=\"/etc/imrc\" -DIMLIB_LIB=\"/usr/lib\" -DSYSCONFDIR=\"/etc\" -I. -I. -I.. -I./.. -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -Wp,-MD,.deps/cache.pp -c cache.c -fPIC -DPIC -o .libs/cache.o In file included from cache.c:5: gdk_imlib_private.h:104: error: expected specifier-qualifier-list before 'XShmSegmentInfo' make[2]: *** [cache.lo] Error 1 make[2]: Leaving directory `/builddir/build/BUILD/imlib-1.9.13/gdk_imlib' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/builddir/build/BUILD/imlib-1.9.13' make: *** [all-recursive-am] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.58804 (%build) It builds ok in just fc5 from the command line, so might be a missing BR or the like under mock? 6. rpmlint output: E: imlib invalid-soname /usr/lib/libimlib-xpm.so libimlib-xpm.so E: imlib invalid-soname /usr/lib/libimlib-jpeg.so libimlib-jpeg.so E: imlib invalid-soname /usr/lib/libimlib-tiff.so libimlib-tiff.so E: imlib invalid-soname /usr/lib/libimlib-ppm.so libimlib-ppm.so E: imlib invalid-soname /usr/lib/libimlib-bmp.so libimlib-bmp.so E: imlib invalid-soname /usr/lib/libimlib-ps.so libimlib-ps.so E: imlib invalid-soname /usr/lib/libimlib-gif.so libimlib-gif.so E: imlib invalid-soname /usr/lib/libimlib-png.so libimlib-png.so invalid-soname : The soname of the library is neither of the form lib<libname>.so.<major> or lib<libname>-<major>.so. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review