Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pengupop - Networked Game in the vein of Move/Puzzle Bobble https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195846 wart@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |wart@xxxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From wart@xxxxxxxxxx 2006-06-18 19:45 EST ------- MUST ==== * rpmlint output clean * Package and spec named appropriately * Source matches upstream: 5c213ecb3cf1bd714dbae771f97ee19a pengupop-2.0.2.tar.gz * GPL license ok, license file included * Spec file legible and in Am. English * No excessive BR: * No locales * No shared libs * No need for a -devel subpackage (no headers, libs, or *.pc) * Not relocatable * Permissions look ok * $RPM_BUILD_ROOT cleaned where needed * Contains code, not content * No need for -doc subpackage * %doc does not affect runtine * .desktop file installed correctly * Does not own directories that it shouldn't * Builds and packages on mock for: FC4-i386, FC4-x86_64, FC5-i386, FC5-x86_64 MUSTFIX ======= * Missing BR: desktop-file-utils * The %description refers to screenshots which aren't visible in the spec. Best just to remove the second paragraph from the %description. * In the desktop-file-install, use $RPM_BUILD_ROOT instead of ${RPM_BUILD_ROOT} for consistency. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review