Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amsn : msn messenger clone https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185951 paul@xxxxxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul@xxxxxxxxxxxxxxxxxxxxxx ------- Additional Comments From paul@xxxxxxxxxxxxxxxxxxxxxx 2006-06-18 18:21 EST ------- The $RPM_BUILD_ROOTs need to be consistent either ${RPM_BUILD_ROOT} or easier, %{buildroot}, but don't mix them. You're also taking ownership of directories (by the looks of it) Instead of %{_datadir}/amsn/foo/ use %{_datadir}/amsn/foo/*.zip (for example) You cannot guarantee that later on someone won't create a plugin which needs to be added to the directory "owned" by the package Is there not other languages for this package? If there is - under the %install %find_lang {name} Then on the files line %files -f %{name}.lang However, some apps install the language files as part of the make install, so you may find this step fails. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review