Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dispatcher https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188440 ------- Additional Comments From cgoorah@xxxxxxxxxxxx 2006-06-18 14:33 EST ------- This is not an official review. As said below, (In reply to comment #1) > * Remove the entire Requires line, rpm can figure it out from BuildRequires > drop libglade2 as Requires > * Keep lines to 80 characters or less (%description) Break your description in 4 lines, like : Dispatcher is a short time scheduler simulator. It was implemented for Operating Systems examination at Naples University Federico II. Fcfs, round robin, virtula round robin and priority schedulers are now available. > * Do not include /usr/share/doc, it is part of the standard hierarchy, the %doc > macro does that yes, remove the line %{_datadir}/* Ill advise you to use %{_docdir}/%{name}/* rather than %{_datadir}/doc/%{name}/* > > See the packaging guideslines on the wiki. include in both %post and %postun touch --no-create %{_datadir}/icons/hicolor || : if [ -x %{_bindir}/gtk-update-icon-cache ]; then %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : fi so that it could look as %post /sbin/ldconfig touch --no-create %{_datadir}/icons/hicolor || : if [ -x %{_bindir}/gtk-update-icon-cache ]; then %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : fi in desktop-file-install add --add-category Engineering \ drop the zero-length %doc - CREDITS AUTHORS ChangeLog TODO Here is my updated spec file, http://beta.glwb.info/dispatcher.spec maybe you can use it afterwards, bear in mind that the following are not yet fixed: > * Do not include static archives if they are not needed. If they are used to > compile against split them off into a devel sub package. W: dispatcher devel-file-in-non-devel-package /usr/lib/dispatcher/libfcfs.a A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. W: dispatcher devel-file-in-non-devel-package /usr/lib/dispatcher/librr.a A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. W: dispatcher devel-file-in-non-devel-package /usr/lib/dispatcher/libpriority.a A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. W: dispatcher devel-file-in-non-devel-package /usr/lib/dispatcher/libvrr.a A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review